rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

WIP: Resolve "CMB - Move warranty creation to the Warranty Handler for CMBJobOrderHandler" #1155

Closed
korina.cordero wants to merge 0 commits from 308-cmb-move-warranty-creation-to-the-warranty-handler-for-cmbjoborderhandler into master
pull from: 308-cmb-move-warranty-creation-to-the-warranty-handler-for-cmbjoborderhandler
merge into: rgutierrez:master
Conversation 3 Commits - Files changed -
korina.cordero commented 2020-01-23 03:21:46 +00:00 (Migrated from gitlab.com)
Copy link

Closes #308

Closes #308
korina.cordero commented 2020-01-23 07:27:15 +00:00 (Migrated from gitlab.com)
Copy link

added 125 commits

  • 37a83099 - Merge branch '265-cmb-project' of gitlab.com:jankstudio/resq into origin/265-cmb-project
  • f1cc1dfa - Create interface for invoice creator. #265
  • cce4638c - Rename invoice creator for resq. Make most public methods in invoice creator protected. #265
  • dc2eecbe - Rename InvoiceCreator to InvoiceGenerator. #265
  • 89ec286a - Rename processCriteria to generateInvoice. Added constants to invoice generator. #265
  • cf8c3bb8 - Move setting of invoice status and createdby inside the invoice generator. #265
  • ca97897a - Move the saving of new job order to a job order generator service. #265
  • b129609d - Refactor submission of updated job order. #265
  • 7f973fd1 - Merge branch 'master' of gitlab.com:jankstudio/resq into origin/265-cmb-project
  • f766965f - Add checking for invoice change. #265
  • 98a6bfc8 - Create invoice and job generator for cmb. Modify services.yaml for cmb. #265
  • 6e3be9ed - Rename from Cmb to CMB. #265
  • 6c3bc652 - Merge branch 'origin/265-cmb-project' into '270-final-cmb-fixes'
  • 37c0945d - Move the validation for incoming and editing job orders from the controller to the service. #270
  • bd869631 - Move the dispatch and assign rider to job order to the service. #270
  • 7754ddc5 - Move the assign rider, dispatch, fulfill, and cancel job order code to the service. #270
  • 34dc6193 - Move the initialization of parameters for new and edit job order forms to the service. #270
  • 2e2f4315 - Move the initialization of parameters for view all and processing job order...
  • 365b316d - Add exception handling to the job order service. #270
  • a7b5341f - Move the initialization of the fulfillment and hub forms to the service. #270
  • 12555f34 - Move the initialization of rider and hub forms and hub reassignment to the job order service. #270
  • e6482d44 - Move reassignment of hub and rider to the job order service. #270
  • 304ef327 - Move reject hub to the job order service. #270
  • 7de72e2c - Move unlock processor and unlock assignor to the job order service. #270
  • 2f555483 - Move generate PDF form to the job order service. #270
  • 7989f6b6 - Move retrieval of job order rows to the job service. #270
  • 08bd23fe - Fix issue of invalid meta urls. #270
  • f205f04b - Move the invoice generation out of the job order service and into the invoice...
  • 59807151 - Add command to add battery manufacturers from given csv file. #270
  • 987668ff - Add command to add battery models from given csv file. #270
  • 5348d2c5 - Add command to add battery sizes from given csv file. #270
  • a29ea875 - Add command to add batteries. #270
  • 54c98711 - merge import batter commands under one command. #270
  • 5ab7cd6e - Add vehicle and vehicle manufacturers in the import command. #270
  • 54a367af - Add images and icons for cmb. Add messages for cmb. #270
  • 2b48c702 - Fix for fatal error in command. #270
  • dcd34f6f - Fix adding of compatible batteries to vehicles. #270
  • 547c13d7 - Fix the adding of compatible batteries for a vehicle. #270
  • f6df19a5 - Add sql script that deletes the data from battery and vehicle tables. #270
  • eb0e19d2 - Add country code prefix to messages. Made the country code a constant. #270
  • a9ed02b0 - Limit the service types to 2 for POC. Have job order return which twig template to display. #270
  • 610bbdcc - Add trade in type for cmb. #270
  • 7e446883 - Add to translation file default point for map. #270
  • a8792c32 - Set the default point for maps. #270
  • 111bb55a - Add command to add prices to batteries using a csv file. #270
  • 7adcb524 - Add command to add tradein prices to battery sizes using a csv file. #270
  • c0d363dd - Redo the import battery data command. #270
  • 02b88bca - Redo the battery vehicle compatibility command. #270
  • 6d0af269 - Redo the import tradein price command. #270
  • 361b8c04 - Change century logo in main template #270
  • 906cf2b6 - Add normalize name method to process special cases for battery size. #270
  • eb6e3118 - Merge branch '270-final-cmb-fixes' of gitlab.com:jankstudio/resq into 270-final-cmb-fixes
  • c6b31569 - Create service types for CMB. #270
  • c2fbb75a - Change Delivery Instructions label to Delivery Instructions - CarFix Job Order No. #270
  • ff58ccf9 - Add autocomplete for maps in job order. Set the default region in translation files. #270
  • 74e09384 - Add autocomplete for maps in outlet, hub, and partner. #270
  • e7584b10 - Add warranty creation after a job order is fulfilled. #270
  • a2094758 - Add warranty creation when rider confirms payment of JO. #270
  • 26d2dab6 - Remove warranty creation when service type is battery replacement under warranty. #270
  • 01ffdea2 - Add map to Dashboard. #270
  • 76b291f6 - Add the rider tracker service to retrieve and display all rider locations. #270
  • c05921cd - Add autorefresh for rider locations in map. #270
  • f5606d83 - Add label to rider markers. #270
  • 29cc7374 - Add custom trade in types, warranty class, and modes of payment. #270
  • c3195418 - Add command to seed current rider sessions to redis cache. #270
  • f70155a1 - Update redis cache for rider session when rider registers or logs in. #270
  • 934afece - Remove unnecessary comments from command. #270
  • 2bb213ef - Move the dashboard routes to home.yaml. #270
  • 954ae0e2 - Removed the color, status, and fuel type fields for customer vehicle. #270
  • 9165fa1e - Remove error_logs. #270
  • a0ad1b00 - Add asterisks to required fields for job order. #270
  • 341db637 - Create a twig template for job order for resq, separate from cmb. #270
  • 58c671fe - Add TODO for country code prefix. #270
  • d385d32d - Move the adding of customer and customer vehicle to customer handler service. #270
  • 50e54f6a - Move the update of customer and customer vehicle to customer handler service. #270
  • 0a8ba8ca - Remove old implementation for update customer. #270
  • 3a33a16c - Move the loading of customer list page to the customer service. #270
  • fb6823d2 - Move the customer list to the customer handler service. #270
  • cc3db5b5 - Move the delete customer to the service. #270
  • 8f875f1e - Move getCustomerVehicles to the customer handler service. #270
  • 174f0142 - Move getCustomerVehicleInfo to the customer handler service. #270
  • 4549e124 - Add job order queueing for riders assignments. #270
  • 15339877 - Add a TODO for the JobHandlerInterface. #270
  • 9e9dba95 - Change the map in the Dashboard to use leaflet and openmaps. #270
  • ade2c3b5 - Add map manager interface. #270
  • e2dd980a - Rename twig block for javascript. #270
  • 505fa86f - Fix console error when google or bing maps are used. #270
  • 734aaac3 - Add display of rider markers for OSM. #270
  • 93692415 - Add rider id to marker popup. #270
  • d04a6976 - Use OpenStreetMap for map in incoming form. #270
  • 5bdc1a7f - Use OpenStreetMap for map in incoming JO form. #270
  • bf223103 - Change implementation of all maps for job order to OpenStreet. #270
  • fdf68618 - Change icons for the hub map. #270
  • 8bbe245c - Add snippet and comments that will not display the riders by default. #270
  • 8e331495 - Add TODO for the OSM implementation for job order. #270
  • 185ac8aa - Add TODO for the access token. #270
  • 494ae854 - Add OpenStreet implementation to resq form. #270
  • 2f3e8df6 - Fix dashboard map bug when rider has no assigned hub #270
  • 5b2b5654 - Add default resq services and comment out cmb for easy swap #270
  • 5852b825 - Make resq translation file the default #270
  • bd1dd36e - Prettify the map in the dashboard #270
  • 008e482f - Modify dashboard to display customers and riders with popup details #270
  • e4277b89 - Remove footer #270
  • 1b6727ca - Expand map to 100% height #270
  • 2d023b5e - Fix location issue in incoming job order. #270
  • a21d0509 - Fix centering issue for hub map when dispatching a job order. #270
  • 51850d02 - Add one step job order process form #270
  • 60391966 - Add form tags for the one step form. #270
  • 0771f2b8 - Add selection of hub. #270
  • 72abf2f2 - Add rider assignment section to form. #270
  • 0ed4e102 - Add rider assignment to one step form. #270
  • b7b673fd - Add rider selection to one step form. #270
  • ed2975e8 - Add validation when submitting a one step job order. #270
  • 79ab6061 - Add saving of one step job order data. #270
  • 3a167f0b - Add links and routes to editing a one step job order form. #270
  • 8da95f2e - Add saving of updated form for one step job order. #270
  • 99e84850 - Display invoice details for editing one step form. #270
  • a92c8c90 - Added a di after battery details for Invoice. #270
  • 35f0d9c7 - Add riders to one step job order map. #270
  • 260c2187 - Added one step form for CMB. #270
  • d6015978 - Merge branch '270-final-cmb-fixes' of gitlab.com:jankstudio/resq into...
  • d418f0ff - Remove hardcoded prefix from customer. Add country code to .env and services.yaml. #307
  • 026a1aa4 - Merge branch '270-final-cmb-fixes' of gitlab.com:jankstudio/resq into...
  • 8727c227 - Merge branch '307-cmb-fix-customer-hard-coded-country-code' of...
  • d569c666 - Add warranty creation when JO is fulfilled to ResqJobOrderHandler. #305

Compare with previous version

added 125 commits <ul><li>37a83099 - Merge branch &#39;265-cmb-project&#39; of gitlab.com:jankstudio/resq into origin/265-cmb-project</li><li>f1cc1dfa - Create interface for invoice creator. #265</li><li>cce4638c - Rename invoice creator for resq. Make most public methods in invoice creator protected. #265</li><li>dc2eecbe - Rename InvoiceCreator to InvoiceGenerator. #265</li><li>89ec286a - Rename processCriteria to generateInvoice. Added constants to invoice generator. #265</li><li>cf8c3bb8 - Move setting of invoice status and createdby inside the invoice generator. #265</li><li>ca97897a - Move the saving of new job order to a job order generator service. #265</li><li>b129609d - Refactor submission of updated job order. #265</li><li>7f973fd1 - Merge branch &#39;master&#39; of gitlab.com:jankstudio/resq into origin/265-cmb-project</li><li>f766965f - Add checking for invoice change. #265</li><li>98a6bfc8 - Create invoice and job generator for cmb. Modify services.yaml for cmb. #265</li><li>6e3be9ed - Rename from Cmb to CMB. #265</li><li>6c3bc652 - Merge branch &#39;origin/265-cmb-project&#39; into &#39;270-final-cmb-fixes&#39;</li><li>37c0945d - Move the validation for incoming and editing job orders from the controller to the service. #270</li><li>bd869631 - Move the dispatch and assign rider to job order to the service. #270</li><li>7754ddc5 - Move the assign rider, dispatch, fulfill, and cancel job order code to the service. #270</li><li>34dc6193 - Move the initialization of parameters for new and edit job order forms to the service. #270</li><li>2e2f4315 - Move the initialization of parameters for view all and processing job order...</li><li>365b316d - Add exception handling to the job order service. #270</li><li>a7b5341f - Move the initialization of the fulfillment and hub forms to the service. #270</li><li>12555f34 - Move the initialization of rider and hub forms and hub reassignment to the job order service. #270</li><li>e6482d44 - Move reassignment of hub and rider to the job order service. #270</li><li>304ef327 - Move reject hub to the job order service. #270</li><li>7de72e2c - Move unlock processor and unlock assignor to the job order service. #270</li><li>2f555483 - Move generate PDF form to the job order service. #270</li><li>7989f6b6 - Move retrieval of job order rows to the job service. #270</li><li>08bd23fe - Fix issue of invalid meta urls. #270</li><li>f205f04b - Move the invoice generation out of the job order service and into the invoice...</li><li>59807151 - Add command to add battery manufacturers from given csv file. #270</li><li>987668ff - Add command to add battery models from given csv file. #270</li><li>5348d2c5 - Add command to add battery sizes from given csv file. #270</li><li>a29ea875 - Add command to add batteries. #270</li><li>54c98711 - merge import batter commands under one command. #270</li><li>5ab7cd6e - Add vehicle and vehicle manufacturers in the import command. #270</li><li>54a367af - Add images and icons for cmb. Add messages for cmb. #270</li><li>2b48c702 - Fix for fatal error in command. #270</li><li>dcd34f6f - Fix adding of compatible batteries to vehicles. #270</li><li>547c13d7 - Fix the adding of compatible batteries for a vehicle. #270</li><li>f6df19a5 - Add sql script that deletes the data from battery and vehicle tables. #270</li><li>eb0e19d2 - Add country code prefix to messages. Made the country code a constant. #270</li><li>a9ed02b0 - Limit the service types to 2 for POC. Have job order return which twig template to display. #270</li><li>610bbdcc - Add trade in type for cmb. #270</li><li>7e446883 - Add to translation file default point for map. #270</li><li>a8792c32 - Set the default point for maps. #270</li><li>111bb55a - Add command to add prices to batteries using a csv file. #270</li><li>7adcb524 - Add command to add tradein prices to battery sizes using a csv file. #270</li><li>c0d363dd - Redo the import battery data command. #270</li><li>02b88bca - Redo the battery vehicle compatibility command. #270</li><li>6d0af269 - Redo the import tradein price command. #270</li><li>361b8c04 - Change century logo in main template #270</li><li>906cf2b6 - Add normalize name method to process special cases for battery size. #270</li><li>eb6e3118 - Merge branch &#39;270-final-cmb-fixes&#39; of gitlab.com:jankstudio/resq into 270-final-cmb-fixes</li><li>c6b31569 - Create service types for CMB. #270</li><li>c2fbb75a - Change Delivery Instructions label to Delivery Instructions - CarFix Job Order No. #270</li><li>ff58ccf9 - Add autocomplete for maps in job order. Set the default region in translation files. #270</li><li>74e09384 - Add autocomplete for maps in outlet, hub, and partner. #270</li><li>e7584b10 - Add warranty creation after a job order is fulfilled. #270</li><li>a2094758 - Add warranty creation when rider confirms payment of JO. #270</li><li>26d2dab6 - Remove warranty creation when service type is battery replacement under warranty. #270</li><li>01ffdea2 - Add map to Dashboard. #270</li><li>76b291f6 - Add the rider tracker service to retrieve and display all rider locations. #270</li><li>c05921cd - Add autorefresh for rider locations in map. #270</li><li>f5606d83 - Add label to rider markers. #270</li><li>29cc7374 - Add custom trade in types, warranty class, and modes of payment. #270</li><li>c3195418 - Add command to seed current rider sessions to redis cache. #270</li><li>f70155a1 - Update redis cache for rider session when rider registers or logs in. #270</li><li>934afece - Remove unnecessary comments from command. #270</li><li>2bb213ef - Move the dashboard routes to home.yaml. #270</li><li>954ae0e2 - Removed the color, status, and fuel type fields for customer vehicle. #270</li><li>9165fa1e - Remove error_logs. #270</li><li>a0ad1b00 - Add asterisks to required fields for job order. #270</li><li>341db637 - Create a twig template for job order for resq, separate from cmb. #270</li><li>58c671fe - Add TODO for country code prefix. #270</li><li>d385d32d - Move the adding of customer and customer vehicle to customer handler service. #270</li><li>50e54f6a - Move the update of customer and customer vehicle to customer handler service. #270</li><li>0a8ba8ca - Remove old implementation for update customer. #270</li><li>3a33a16c - Move the loading of customer list page to the customer service. #270</li><li>fb6823d2 - Move the customer list to the customer handler service. #270</li><li>cc3db5b5 - Move the delete customer to the service. #270</li><li>8f875f1e - Move getCustomerVehicles to the customer handler service. #270</li><li>174f0142 - Move getCustomerVehicleInfo to the customer handler service. #270</li><li>4549e124 - Add job order queueing for riders assignments. #270</li><li>15339877 - Add a TODO for the JobHandlerInterface. #270</li><li>9e9dba95 - Change the map in the Dashboard to use leaflet and openmaps. #270</li><li>ade2c3b5 - Add map manager interface. #270</li><li>e2dd980a - Rename twig block for javascript. #270</li><li>505fa86f - Fix console error when google or bing maps are used. #270</li><li>734aaac3 - Add display of rider markers for OSM. #270</li><li>93692415 - Add rider id to marker popup. #270</li><li>d04a6976 - Use OpenStreetMap for map in incoming form. #270</li><li>5bdc1a7f - Use OpenStreetMap for map in incoming JO form. #270</li><li>bf223103 - Change implementation of all maps for job order to OpenStreet. #270</li><li>fdf68618 - Change icons for the hub map. #270</li><li>8bbe245c - Add snippet and comments that will not display the riders by default. #270</li><li>8e331495 - Add TODO for the OSM implementation for job order. #270</li><li>185ac8aa - Add TODO for the access token. #270</li><li>494ae854 - Add OpenStreet implementation to resq form. #270</li><li>2f3e8df6 - Fix dashboard map bug when rider has no assigned hub #270</li><li>5b2b5654 - Add default resq services and comment out cmb for easy swap #270</li><li>5852b825 - Make resq translation file the default #270</li><li>bd1dd36e - Prettify the map in the dashboard #270</li><li>008e482f - Modify dashboard to display customers and riders with popup details #270</li><li>e4277b89 - Remove footer #270</li><li>1b6727ca - Expand map to 100% height #270</li><li>2d023b5e - Fix location issue in incoming job order. #270</li><li>a21d0509 - Fix centering issue for hub map when dispatching a job order. #270</li><li>51850d02 - Add one step job order process form #270</li><li>60391966 - Add form tags for the one step form. #270</li><li>0771f2b8 - Add selection of hub. #270</li><li>72abf2f2 - Add rider assignment section to form. #270</li><li>0ed4e102 - Add rider assignment to one step form. #270</li><li>b7b673fd - Add rider selection to one step form. #270</li><li>ed2975e8 - Add validation when submitting a one step job order. #270</li><li>79ab6061 - Add saving of one step job order data. #270</li><li>3a167f0b - Add links and routes to editing a one step job order form. #270</li><li>8da95f2e - Add saving of updated form for one step job order. #270</li><li>99e84850 - Display invoice details for editing one step form. #270</li><li>a92c8c90 - Added a di after battery details for Invoice. #270</li><li>35f0d9c7 - Add riders to one step job order map. #270</li><li>260c2187 - Added one step form for CMB. #270</li><li>d6015978 - Merge branch &#39;270-final-cmb-fixes&#39; of gitlab.com:jankstudio/resq into...</li><li>d418f0ff - Remove hardcoded prefix from customer. Add country code to .env and services.yaml. #307</li><li>026a1aa4 - Merge branch &#39;270-final-cmb-fixes&#39; of gitlab.com:jankstudio/resq into...</li><li>8727c227 - Merge branch &#39;307-cmb-fix-customer-hard-coded-country-code&#39; of...</li><li>d569c666 - Add warranty creation when JO is fulfilled to ResqJobOrderHandler. #305</li></ul> [Compare with previous version](/jankstudio/resq/merge_requests/344/diffs?diff_id=72206221&start_sha=1ca2823d51c6a29e4a0626054f7dd6c64a2d4b82)
korina.cordero commented 2020-01-23 07:47:49 +00:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • 2f9f787e - Added CMB CustomerHandler in services.yaml. #305
  • 5ac6127e - Merge branch '307-cmb-fix-customer-hard-coded-country-code' into '270-final-cmb-fixes'
  • 39adfe19 - Merge branch...
  • 2c9f5180 - Move warranty creation when JO is fulfilled to the warranty handler for CMB. #308

Compare with previous version

added 4 commits <ul><li>2f9f787e - Added CMB CustomerHandler in services.yaml. #305</li><li>5ac6127e - Merge branch &#39;307-cmb-fix-customer-hard-coded-country-code&#39; into &#39;270-final-cmb-fixes&#39;</li><li>39adfe19 - Merge branch...</li><li>2c9f5180 - Move warranty creation when JO is fulfilled to the warranty handler for CMB. #308</li></ul> [Compare with previous version](/jankstudio/resq/merge_requests/344/diffs?diff_id=72208216&start_sha=d569c666e36e5ef88a87a8b2f70b3933b8eb5436)
korina.cordero commented 2020-01-23 07:51:06 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API

   
AU

Marshall Battery Feature

  
Bug

Bug

  
CRM Enhancements

   
Mobile API

   
Nice to have

   
Phase 2

Local Phase 2

No labels
API
AU
Bug
CRM Enhancements
Mobile API
Nice to have
Phase 2
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rgutierrez/resq#1155
No description provided.
Delete branch "308-cmb-move-warranty-creation-to-the-warranty-handler-for-cmbjoborderhandler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?