rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Restore using isset instead of in_array for number and vehicle whitelisting on customer

Browse source
This commit is contained in:
Ramon Gutierrez 2018-02-04 16:55:06 +08:00
parent 2b0f97a678
commit dd5fbf7cd6
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/Controller/CustomerController.php
View file

@ -397,7 +397,7 @@ class CustomerController extends BaseController
// add to list of vehicles to keep // add to list of vehicles to keep
$vehicle_ids[] = $cust_vehicle->getID(); $vehicle_ids[$cust_vehicle->getID()] = true;
} }
// cleanup // cleanup
@ -405,7 +405,7 @@ class CustomerController extends BaseController
$cvs = $cust->getVehicles(); $cvs = $cust->getVehicles();
foreach ($cvs as $cv) foreach ($cvs as $cv)
{ {
if (!in_array($cv->getID(), $vehicle_ids)) if (!isset($vehicle_ids[$cv->getID()]))
{ {
$cust->removeVehicle($cv); $cust->removeVehicle($cv);
$em->remove($cv); $em->remove($cv);
@ -437,7 +437,7 @@ class CustomerController extends BaseController
} }
// add to list of numbers to keep // add to list of numbers to keep
//$number_ids[] = $mobile_number->getID(); $number_ids[$mobile_number->getID()] = true;
} }
error_log('cleanup'); error_log('cleanup');
@ -449,7 +449,7 @@ class CustomerController extends BaseController
{ {
error_log($mn->getID()); error_log($mn->getID());
error_log(print_r($number_ids, true)); error_log(print_r($number_ids, true));
if (!in_array($mn->getID(), $number_ids)) if (!isset($number_ids[$mn->getID()]))
{ {
error_log('removing ' . $mn->getID()); error_log('removing ' . $mn->getID());
$cust->removeMobileNumber($mn); $cust->removeMobileNumber($mn);