From dd5fbf7cd61c0a871c5e655741903351fb11243b Mon Sep 17 00:00:00 2001 From: Ramon Gutierrez Date: Sun, 4 Feb 2018 16:55:06 +0800 Subject: [PATCH] Restore using isset instead of in_array for number and vehicle whitelisting on customer --- src/Controller/CustomerController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Controller/CustomerController.php b/src/Controller/CustomerController.php index 09670f79..5ba29744 100644 --- a/src/Controller/CustomerController.php +++ b/src/Controller/CustomerController.php @@ -397,7 +397,7 @@ class CustomerController extends BaseController // add to list of vehicles to keep - $vehicle_ids[] = $cust_vehicle->getID(); + $vehicle_ids[$cust_vehicle->getID()] = true; } // cleanup @@ -405,7 +405,7 @@ class CustomerController extends BaseController $cvs = $cust->getVehicles(); foreach ($cvs as $cv) { - if (!in_array($cv->getID(), $vehicle_ids)) + if (!isset($vehicle_ids[$cv->getID()])) { $cust->removeVehicle($cv); $em->remove($cv); @@ -437,7 +437,7 @@ class CustomerController extends BaseController } // add to list of numbers to keep - //$number_ids[] = $mobile_number->getID(); + $number_ids[$mobile_number->getID()] = true; } error_log('cleanup'); @@ -449,7 +449,7 @@ class CustomerController extends BaseController { error_log($mn->getID()); error_log(print_r($number_ids, true)); - if (!in_array($mn->getID(), $number_ids)) + if (!isset($number_ids[$mn->getID()])) { error_log('removing ' . $mn->getID()); $cust->removeMobileNumber($mn);