rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Resolve "Allow super admin to do rider assignment regardless of locking" #899

Merged
jankstudio merged 1 commit from 106-allow-super-admin-to-do-rider-assignment-regardless-of-locking into master 2018-04-26 20:21:40 +00:00
Conversation 2 Commits 1 Files changed 1 +25 -17
1 changed files with 25 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
src/Controller/JobOrderController.php
View file

@ -1024,27 +1024,35 @@ class JobOrderController extends BaseController
throw $this->createNotFoundException('The job order does not have an assigning status'); throw $this->createNotFoundException('The job order does not have an assigning status');
} }
// check if hub is assigned to current user // check if super user
$user_hubs = $this->getUser()->getHubs();
if (!in_array($obj->getHub()->getID(), $user_hubs))
{
$em->getConnection()->rollback();
throw $this->createNotFoundException('The job order is not on a hub assigned to this user');
}
// check if we are the assignor
$assignor = $obj->getAssignedBy();
$user = $this->getUser(); $user = $this->getUser();
if ($user->isSuperAdmin())
if ($assignor != null && $assignor->getID() != $user->getID())
{ {
$em->getConnection()->rollback(); // do nothing, just allow page to be accessed
throw $this->createAccessDeniedException('Not the assignor');
} }
else
{
// check if hub is assigned to current user
$user_hubs = $this->getUser()->getHubs();
if (!in_array($obj->getHub()->getID(), $user_hubs))
{
$em->getConnection()->rollback();
throw $this->createNotFoundException('The job order is not on a hub assigned to this user');
}
// make this user be the assignor // check if we are the assignor
$obj->setAssignedBy($user); $assignor = $obj->getAssignedBy();
$em->flush();
if ($assignor != null && $assignor->getID() != $user->getID())
{
$em->getConnection()->rollback();
throw $this->createAccessDeniedException('Not the assignor');
}
// make this user be the assignor
$obj->setAssignedBy($user);
$em->flush();
}
$em->getConnection()->commit(); $em->getConnection()->commit();
} }