From 4fb28174c57f0f014a203a9b28d5c888cb82f6ee Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Mon, 2 May 2022 02:45:38 +0000 Subject: [PATCH 1/3] Normalize fuel type and status condition of vehicle when adding customer vehicle via app. #662 --- src/Controller/APIController.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php index 73643bbf..f08e2a05 100644 --- a/src/Controller/APIController.php +++ b/src/Controller/APIController.php @@ -630,8 +630,8 @@ class APIController extends Controller implements LoggedController ->setPlateNumber($req->request->get('plate_num')) ->setModelYear($req->request->get('model_year')) ->setColor($req->request->get('color')) - ->setFuelType($req->request->get('fuel_type')) - ->setStatusCondition($req->request->get('condition')); + ->setFuelType($this->normalizeName($req->request->get('fuel_type'))) + ->setStatusCondition($this->normalizename($req->request->get('condition'))); // set warranty code and expiration // TODO: check warranty requirements @@ -4695,4 +4695,9 @@ class APIController extends Controller implements LoggedController return $jo_data; } + + protected function normalizeName($name) + { + return trim(strtolower($name)); + } } -- 2.43.5 From 3e61bdb89c992dbe627bd584006bbdcfefbb4050 Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Mon, 2 May 2022 06:14:53 +0000 Subject: [PATCH 2/3] Fix typo for call to normalize text. #662 --- src/Controller/APIController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php index f08e2a05..19802b22 100644 --- a/src/Controller/APIController.php +++ b/src/Controller/APIController.php @@ -631,7 +631,7 @@ class APIController extends Controller implements LoggedController ->setModelYear($req->request->get('model_year')) ->setColor($req->request->get('color')) ->setFuelType($this->normalizeName($req->request->get('fuel_type'))) - ->setStatusCondition($this->normalizename($req->request->get('condition'))); + ->setStatusCondition($this->normalizeName($req->request->get('condition'))); // set warranty code and expiration // TODO: check warranty requirements -- 2.43.5 From 0ea329655fd326a756f527e5abb5c0fff7b490a9 Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Mon, 2 May 2022 06:22:17 +0000 Subject: [PATCH 3/3] Rename function to normalizeString. #662 --- src/Controller/APIController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php index 19802b22..f1721149 100644 --- a/src/Controller/APIController.php +++ b/src/Controller/APIController.php @@ -630,8 +630,8 @@ class APIController extends Controller implements LoggedController ->setPlateNumber($req->request->get('plate_num')) ->setModelYear($req->request->get('model_year')) ->setColor($req->request->get('color')) - ->setFuelType($this->normalizeName($req->request->get('fuel_type'))) - ->setStatusCondition($this->normalizeName($req->request->get('condition'))); + ->setFuelType($this->normalizeString($req->request->get('fuel_type'))) + ->setStatusCondition($this->normalizeString($req->request->get('condition'))); // set warranty code and expiration // TODO: check warranty requirements @@ -4696,8 +4696,8 @@ class APIController extends Controller implements LoggedController return $jo_data; } - protected function normalizeName($name) + protected function normalizeString($string) { - return trim(strtolower($name)); + return trim(strtolower($string)); } } -- 2.43.5