Resq - new API calls for version check and display order screen #392

Closed
opened 2020-04-30 03:57:23 +00:00 by korina.cordero · 12 comments
korina.cordero commented 2020-04-30 03:57:23 +00:00 (Migrated from gitlab.com)

version check:
the app, whenever it's started, will issue a call. incoming parameter would be the current version and output will be need_update = true or false

so on the backend, we make an entry in the .env, API_VERSION, so API version will be .. breaking changes will happen with major version change so if major version change is different update is required.

call to check if we need to prompt for book now vs advance order:
this one has to be modifiable because we're changing it after lockdown. no input parameters needed. we simply check the time.

5 pm - 8 am means that we automatically display advance order and disallow book now.
8 am to 5 pm book now

so return is display_schedule_choice = true or false

5 pm to 8 am (not inclusive) is false

8 am to 5 pm is true.

when ecq is lifted, we make it return true all the time by erasing the time check. Put in a TODO on that after ECQ, the api call returns true.

version check: the app, whenever it's started, will issue a call. incoming parameter would be the current version and output will be need_update = true or false so on the backend, we make an entry in the .env, API_VERSION, so API version will be <major version>.<minor version>. breaking changes will happen with major version change so if major version change is different update is required. call to check if we need to prompt for book now vs advance order: this one has to be modifiable because we're changing it after lockdown. no input parameters needed. we simply check the time. 5 pm - 8 am means that we automatically display advance order and disallow book now. 8 am to 5 pm book now so return is display_schedule_choice = true or false 5 pm to 8 am (not inclusive) is false 8 am to 5 pm is true. when ecq is lifted, we make it return true all the time by erasing the time check. Put in a TODO on that after ECQ, the api call returns true.
korina.cordero commented 2020-04-30 03:58:04 +00:00 (Migrated from gitlab.com)

created merge request !436 to address this issue

created merge request !436 to address this issue
korina.cordero commented 2020-04-30 03:58:04 +00:00 (Migrated from gitlab.com)

mentioned in merge request !436

mentioned in merge request !436
korina.cordero commented 2020-04-30 05:38:59 +00:00 (Migrated from gitlab.com)

mentioned in commit b3b46bca7b

mentioned in commit b3b46bca7bbbccccb027c1038045be78bacc3edb
korina.cordero commented 2020-04-30 07:00:36 +00:00 (Migrated from gitlab.com)

mentioned in commit b66ebf7eeb

mentioned in commit b66ebf7eebd2d1b84d6ce7c0d624fe762177e4d2
jankstudio commented 2020-04-30 07:03:02 +00:00 (Migrated from gitlab.com)

closed via merge request !436

closed via merge request !436
jankstudio commented 2020-04-30 07:03:02 +00:00 (Migrated from gitlab.com)

mentioned in commit 6ecc1166e3

mentioned in commit 6ecc1166e3362cf690911fec34e6ea642504c9e6
korina.cordero commented 2020-04-30 07:17:42 +00:00 (Migrated from gitlab.com)

mentioned in commit da16bf54a3

mentioned in commit da16bf54a32d1ef8dd946feb8e17c466468b3621
korina.cordero commented 2020-04-30 07:19:09 +00:00 (Migrated from gitlab.com)

mentioned in merge request !437

mentioned in merge request !437
korina.cordero commented 2020-04-30 07:26:31 +00:00 (Migrated from gitlab.com)

mentioned in commit 6effa53997

mentioned in commit 6effa5399748dd9a7f2cbcbd6b5325c132e68cfd
korina.cordero commented 2020-04-30 07:32:48 +00:00 (Migrated from gitlab.com)

mentioned in commit ae17b23b2c

mentioned in commit ae17b23b2cb2aa1f30b7921d15b51f2f5fe2e1ce
korina.cordero commented 2020-04-30 07:34:27 +00:00 (Migrated from gitlab.com)

mentioned in commit 7d4212195d

mentioned in commit 7d4212195df1b88088a71321cc248fa4d0ff472b
jankstudio commented 2020-04-30 07:35:26 +00:00 (Migrated from gitlab.com)

mentioned in commit 13d3cfd3ee

mentioned in commit 13d3cfd3ee1d8383bef7aa8a0734fd6f308ac626
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rgutierrez/resq#392
No description provided.