TRANS - method to check if new battery #336

Closed
opened 2020-02-10 06:25:44 +00:00 by korina.cordero · 6 comments
korina.cordero commented 2020-02-10 06:25:44 +00:00 (Migrated from gitlab.com)

// create warranty
if (($jo->getServiceType() == ServiceType::BATTERY_REPLACEMENT_NEW) ||
($jo->getServiceType() == CMBServiceType::BATTERY_REPLACEMENT_NEW))

the more manageable way is to make a method in the JO service to say if it's a new battery or not

$jo_service->checkIfNewBattery($jo)

that way, it's generic

// create warranty if (($jo->getServiceType() == ServiceType::BATTERY_REPLACEMENT_NEW) || ($jo->getServiceType() == CMBServiceType::BATTERY_REPLACEMENT_NEW)) the more manageable way is to make a method in the JO service to say if it's a new battery or not $jo_service->checkIfNewBattery($jo) that way, it's generic
korina.cordero commented 2020-02-11 03:01:49 +00:00 (Migrated from gitlab.com)

mentioned in merge request !376

mentioned in merge request !376
korina.cordero commented 2020-02-11 03:01:49 +00:00 (Migrated from gitlab.com)

created merge request !376 to address this issue

created merge request !376 to address this issue
korina.cordero commented 2020-02-11 05:55:15 +00:00 (Migrated from gitlab.com)

mentioned in commit f0212cc6d4

mentioned in commit f0212cc6d4a20487e4cb77511686b4d5de5f059a
korina.cordero commented 2020-02-12 02:33:27 +00:00 (Migrated from gitlab.com)

mentioned in commit c81a56c6e6

mentioned in commit c81a56c6e6b97c8055cfba9441fb41239d708fcc
korina.cordero commented 2020-02-12 02:34:22 +00:00 (Migrated from gitlab.com)

mentioned in merge request !378

mentioned in merge request !378
korina.cordero commented 2020-02-14 03:42:10 +00:00 (Migrated from gitlab.com)

closed

closed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rgutierrez/resq#336
No description provided.