Plate number validation #211

Closed
opened 2019-05-14 09:00:52 +00:00 by jankstudio · 6 comments
jankstudio commented 2019-05-14 09:00:52 +00:00 (Migrated from gitlab.com)

Client wants to make plate number validation friendlier. They want these rules:

  1. alphanumeric
  2. no spaces even in between the characters
  3. maximum length 11

Currently, plate number validation is done in Warranty entity via cleanPlateNumber method

Task is to:

  1. replace the checks in cleanPlateNumber with the check they want, recommending regex to handle it. Make sure to only comment out the old code, because we may need it later.
  2. No making of service this time. This makes more sense as a static method since we have no other dependencies except the string.
Client wants to make plate number validation friendlier. They want these rules: 1. alphanumeric 2. no spaces even in between the characters 3. maximum length 11 Currently, plate number validation is done in Warranty entity via cleanPlateNumber method Task is to: 1. replace the checks in cleanPlateNumber with the check they want, recommending regex to handle it. Make sure to only comment out the old code, because we may need it later. 2. No making of service this time. This makes more sense as a static method since we have no other dependencies except the string.
jankstudio commented 2019-05-14 09:01:10 +00:00 (Migrated from gitlab.com)

assigned to @korina.cordero

assigned to @korina.cordero
korina.cordero commented 2019-05-14 09:18:28 +00:00 (Migrated from gitlab.com)

created merge request !247 to address this issue

created merge request !247 to address this issue
korina.cordero commented 2019-05-14 09:18:34 +00:00 (Migrated from gitlab.com)

mentioned in merge request !247

mentioned in merge request !247
korina.cordero commented 2019-05-15 02:18:16 +00:00 (Migrated from gitlab.com)

mentioned in commit 2a501e60e4

mentioned in commit 2a501e60e4a901ae74e09d96c739aa726ad6d919
jankstudio commented 2019-05-27 02:01:21 +00:00 (Migrated from gitlab.com)

closed via merge request !247

closed via merge request !247
jankstudio commented 2019-05-27 02:01:21 +00:00 (Migrated from gitlab.com)

mentioned in commit 6501f6c0e3

mentioned in commit 6501f6c0e3845a91edb74f52b099de0cf4873c29
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rgutierrez/resq#211
No description provided.