Generate warranty entries for existing job orders #187

Closed
opened 2019-02-20 03:49:09 +00:00 by jankstudio · 9 comments
jankstudio commented 2019-02-20 03:49:09 +00:00 (Migrated from gitlab.com)

Make a symfony command to generate warranty table entries from existing job_order entries.

Make a symfony command to generate warranty table entries from existing job_order entries.
jankstudio commented 2019-02-20 03:49:15 +00:00 (Migrated from gitlab.com)

assigned to @jankstudio

assigned to @jankstudio
jankstudio commented 2019-02-20 03:49:19 +00:00 (Migrated from gitlab.com)

assigned to @korina.cordero and unassigned @jankstudio

assigned to @korina.cordero and unassigned @jankstudio
korina.cordero commented 2019-02-20 05:08:00 +00:00 (Migrated from gitlab.com)

created merge request !218 to address this issue

created merge request !218 to address this issue
korina.cordero commented 2019-02-20 05:08:00 +00:00 (Migrated from gitlab.com)

mentioned in merge request !218

mentioned in merge request !218
korina.cordero commented 2019-02-27 03:27:40 +00:00 (Migrated from gitlab.com)

mentioned in commit 084d058341

mentioned in commit 084d058341f43e21831e30f7f2692b76e8307fae
jankstudio commented 2019-04-11 05:44:21 +00:00 (Migrated from gitlab.com)

ServiceType filtered should be ServiceType::BATTERY_REPLACEMENT_NEW

warranty period computation should be based on job order warranty class

  • if WarrantyClass::PRIVATE - getWarrantyPrivate
  • if WarrantyClass::COMMERCIAL - getWarrantyCommercial
  • if WarrantyClass::TNV - getWarrantyTNV (see issue 203, do issue 203 first then pull to this branch)

make sure to check if the warranty entry already exists, check plate number and date expire. if it exists already, no need to add, otherwise, we'd get duplicates.

ServiceType filtered should be ServiceType::BATTERY_REPLACEMENT_NEW warranty period computation should be based on job order warranty class - if WarrantyClass::PRIVATE - getWarrantyPrivate - if WarrantyClass::COMMERCIAL - getWarrantyCommercial - if WarrantyClass::TNV - getWarrantyTNV (see issue 203, do issue 203 first then pull to this branch) make sure to check if the warranty entry already exists, check plate number and date expire. if it exists already, no need to add, otherwise, we'd get duplicates.
korina.cordero commented 2019-04-12 01:44:26 +00:00 (Migrated from gitlab.com)

mentioned in commit beeaed5c00

mentioned in commit beeaed5c001af87a16d88607d1153a9e0d252b42
jankstudio commented 2019-05-27 02:10:38 +00:00 (Migrated from gitlab.com)

closed via merge request !218

closed via merge request !218
jankstudio commented 2019-05-27 02:10:39 +00:00 (Migrated from gitlab.com)

mentioned in commit 46bc686372

mentioned in commit 46bc686372a8264a7f0346e07252ca7ec25e47f1
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rgutierrez/resq#187
No description provided.