From e3bca2c07d332ee243466808e77c1a84d3c5d698 Mon Sep 17 00:00:00 2001
From: Kendrick Chan <kc@jankstudio.com>
Date: Wed, 7 Aug 2019 22:37:08 +0800
Subject: [PATCH] Add null checks and set to '' for json data #247

---
 src/Controller/APIController.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php
index fcd49749..e6b778c7 100644
--- a/src/Controller/APIController.php
+++ b/src/Controller/APIController.php
@@ -701,11 +701,11 @@ class APIController extends Controller
         $cvs = $cust->getVehicles();
         foreach ($cvs as $cv)
         {
-            $battery_id = null;
+            $battery_id = '';
             if ($cv->getCurrentBattery() != null)
                 $battery_id = $cv->getCurrentBattery()->getID();
 
-            $wty_ex = null;
+            $wty_ex = '';
             if ($cv->getWarrantyExpiration() != null)
                 $wty_ex = $cv->getWarrantyExpiration()->format('Y-m-d');
 
@@ -721,7 +721,7 @@ class APIController extends Controller
                 'color' => $cv->getColor(),
                 'condition' => $cv->getStatusCondition(),
                 'fuel_type' => $cv->getFuelType(),
-                'wty_code' => $cv->getWarrantyCode(),
+                'wty_code' => $cv->getWarrantyCode() ?? $cv->getWarrantyCode() : '',
                 'wty_expire' => $wty_ex,
                 'curr_batt_id' => $battery_id,
                 'is_motolite' => $cv->hasMotoliteBattery() ? 1 : 0,
@@ -1950,12 +1950,15 @@ class APIController extends Controller
         if (!(is_null($warranty->getBatteryModel()))) {
             $batt_model = $warranty->getBatteryModel()->getName();
         }
+
         if (!(is_null($warranty->getBatterySize()))) {
             $batt_size = $warranty->getBatterySize()->getName();
         }
+
         if (!(is_null($warranty->getSAPBattery()))) {
             $sap_batt = $warranty->getSAPBattery()->getID();
         }
+            
         if (!(is_null($warranty->getDateClaim()))) {
             $claim_date = $warranty->getDateClaim()->format("d M Y");
         }
@@ -1965,7 +1968,7 @@ class APIController extends Controller
 
         $warr[] = [
             'id' => $warranty->getID(),
-            'serial' => $warranty->getSerial(),
+            'serial' => $warranty->getSerial() ?? $warranty->getSerial() : '',
             'warranty_class' => $warranty->getWarrantyClass(),
             'plate_number' => $warranty->getPlateNumber(),
             'first_name' => $warranty->getFirstName(),
@@ -1979,7 +1982,7 @@ class APIController extends Controller
             'date_purchase' => $warranty->getDatePurchase()->format("d M Y"),
             'date_expire' => $expiry_date,
             'date_claim' => $claim_date,
-            'claim_from' => $warranty->getClaimedFrom(),
+            'claim_from' => $warranty->getClaimedFrom() ?? $warranty->getClaimedFrom() : '',
             'is_activated' => $warranty->isActivated() ? 1 : 0,
         ];