From e1103cf108a7762ce73357b0f6562a6bcddb86c0 Mon Sep 17 00:00:00 2001 From: Ramon Gutierrez Date: Thu, 4 Jul 2024 15:41:01 +0800 Subject: [PATCH] Move enabled filters list to env #800 --- config/services.yaml | 1 + src/Service/HubSelector.php | 18 ++++++++---------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/config/services.yaml b/config/services.yaml index 2bb23c98..6af4a5d3 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -16,6 +16,7 @@ parameters: android_app_version: "%env(ANDROID_APP_VERSION)%" ios_app_version: "%env(IOS_APP_VERSION)%" insurance_premiums_banner_url: "%env(INSURANCE_PREMIUMS_BANNER_URL)%" + enabled_hub_filters: "%env(ENABLED_HUB_FILTERS)%" services: # default configuration for services in *this* file diff --git a/src/Service/HubSelector.php b/src/Service/HubSelector.php index e706cc84..e5c3b5f1 100644 --- a/src/Service/HubSelector.php +++ b/src/Service/HubSelector.php @@ -39,18 +39,16 @@ class HubSelector $this->rt = $rt; } - // TODO: move this to env or something so we can enable and disable filters without code changes protected function getActiveFilters(): array { - return [ - 'App\Service\HubFilter\Filters\DateAndTimeHubFilter', - 'App\Service\HubFilter\Filters\JoTypeHubFilter', - 'App\Service\HubFilter\Filters\PaymentMethodHubFilter', - 'App\Service\HubFilter\Filters\RiderAvailabilityHubFilter', - 'App\Service\HubFilter\Filters\InventoryHubFilter', - 'App\Service\HubFilter\Filters\RoundRobinHubFilter', - 'App\Service\HubFilter\Filters\MaxResultsHubFilter', - ]; + $fnames = explode(",", $this->container->getParameter('enabled_hub_filters')); + $enabled_filters = []; + + foreach ($fnames as $filter) { + $enabled_filters[] = 'App\\Service\\HubFilter\\Filters\\' . $filter; + } + + return $enabled_filters; } public function find(HubCriteria $criteria)