Fix responses. Add routes for promo. #686

config/routes/tapi.yaml

@@ -22,3 +22,9 @@ tapi_battery_list:
     path: /tapi/vehicles/{vid}/compatible_batteries
     controller: App\Controller\TAPI\BatteryController::getCompatibleBatteries
     methods: [GET]
+
+# promos
+tapi_promo_list:
+    path: /tapi/promos
+    controller: App\Controller\TAPI\PromoController::listPromos
+    methods: [GET]

src/Controller/TAPI/BatteryController.php

@@ -80,4 +80,14 @@ class BatteryController extends APIController
         $message = 'Compatible batteries found.';
         return new APIResponse(true, $message, $data);
     }
+
+    // TODO: might have to put this in a common service since JobOrderController also calls this
+    protected function getBatteryImageURL($req, $batt)
+    {
+        // TODO: workaround for now, we get static image of battery based on model name
+        $filename = trim(strtolower($batt->getModel()->getName())) . '_mobile.jpg';
+        $file_path = $req->getSchemeAndHttpHost() . $this->generateUrl('static_battery_image') . '/' . $filename;
+
+        return $file_path;
+    }
 }

src/Controller/TAPI/JobOrderController.php

@@ -1471,6 +1471,7 @@ class JobOrderController extends APIController
         return $selected_rider;
     }
 
+    // TODO: might have to put this in a common service since BatteryController also calls this
     protected function getBatteryImageURL($req, $batt)
     {
         // TODO: workaround for now, we get static image of battery based on model name

src/Controller/TAPI/PromoController.php

@@ -30,11 +30,16 @@ class PromoController extends APIController
 
         // check required parameters and api key
         $required_params = [];
-        $res = $this->checkParamsAndKey($req, $em, $required_params);
+        $msg = $this->checkRequiredParameters($req, $required_params);
-        if ($res->isError())
+        if ($msg)
-            return $res->getReturnResponse();
+            return new APIResponse(false, $msg);
 
-        return $res->getReturnResponse();
+        $data = [];
+        // TODO: add call to get promos here 
+
+        $message = 'Promos found.';
+
+        return new APIResponse(true, $message, $data);
     }
 
 }