From b6d2726d41aef6f987202b1741469a4945c1a159 Mon Sep 17 00:00:00 2001
From: Kendrick Chan <kc@jankstudio.com>
Date: Fri, 21 Aug 2020 17:42:29 +0800
Subject: [PATCH] Fix caching for rider marker name loading #472

---
 public/assets/js/dashboard_map.js | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/public/assets/js/dashboard_map.js b/public/assets/js/dashboard_map.js
index a13bc851..2df2d69f 100644
--- a/public/assets/js/dashboard_map.js
+++ b/public/assets/js/dashboard_map.js
@@ -335,16 +335,18 @@ class DashboardMap {
         if (this.rider_names.hasOwnProperty(id)) {
             name = this.rider_names[id];
             callback(name);
-        }
+        } else {
+            // ajax call to get it
+            $.ajax({
+                method: "GET",
+                url: rider_url
+            }).done(function(response) {
+                name = response.rider_name;
 
-        // ajax call to get it
-        $.ajax({
-            method: "GET",
-            url: rider_url
-        }).done(function(response) {
-            name = response.rider_name;
-            my.rider_names[id] = name;
-            callback(name);
-        });
+                // set name in cache
+                my.rider_names[id] = name;
+                callback(name);
+            });
+        }
     }
 }