rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Fix issue of wrong JO status set. Add descriptive notes for JOStatus. #382

Browse source
This commit is contained in:
Korina Cordero 2020-04-21 08:12:46 +00:00
parent daa25091db
commit b4c234e5dd
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Controller/APIController.php
View file

@ -1021,7 +1021,7 @@ class APIController extends Controller implements LoggedController
if (!empty($nearest_hub)) if (!empty($nearest_hub))
{ {
$jo->setHub($nearest_hub); $jo->setHub($nearest_hub);
$jo->setStatus(JOStatus::ASSIGNED); $jo->setStatus(JOStatus::RIDER_ASSIGN);
} }
$em->persist($jo); $em->persist($jo);
@ -1035,7 +1035,7 @@ class APIController extends Controller implements LoggedController
$em->persist($event); $em->persist($event);
// check JO status // check JO status
if ($jo->getStatus() == JOStatus::ASSIGNED) if ($jo->getStatus() == JOStatus::RIDER_ASSIGNED)
{ {
// add event logs for hub and rider assignments // add event logs for hub and rider assignments
$hub_assign_event = new JOEvent(); $hub_assign_event = new JOEvent();

14
src/Ramcar/JOStatus.php
View file

@ -4,13 +4,13 @@ namespace App\Ramcar;
class JOStatus extends NameValue class JOStatus extends NameValue
{ {
const PENDING = 'pending'; const PENDING = 'pending'; // NOTE: JO has no hub assigned
const RIDER_ASSIGN = 'rider_assign'; const RIDER_ASSIGN = 'rider_assign'; // NOTE: JO has hub assigned but no rider assigned
const ASSIGNED = 'assigned'; const ASSIGNED = 'assigned'; // NOTE: JO has hub and rider assigned
const IN_TRANSIT = 'in_transit'; const IN_TRANSIT = 'in_transit'; // NOTE: JO's rider is on his way
const IN_PROGRESS = 'in_progress'; const IN_PROGRESS = 'in_progress'; // NOTE: JO fulfillment in progress
const CANCELLED = 'cancelled'; const CANCELLED = 'cancelled'; // NOTE: JO is cancelled
const FULFILLED = 'fulfilled'; const FULFILLED = 'fulfilled'; // NOTE: JO is fulfilled
const COLLECTION = [ const COLLECTION = [
'pending' => 'For Dispatch', 'pending' => 'For Dispatch',