From b198848a47885dd60939201dfb48a01b98c5e045 Mon Sep 17 00:00:00 2001 From: Ramon Gutierrez Date: Fri, 12 Jan 2018 03:14:35 +0800 Subject: [PATCH] Check if acls is populated before doing foreach --- src/Controller/RoleController.php | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/Controller/RoleController.php b/src/Controller/RoleController.php index 465ca2bb..36a6ede2 100644 --- a/src/Controller/RoleController.php +++ b/src/Controller/RoleController.php @@ -159,9 +159,13 @@ class RoleController extends BaseController // acl attributes $acl_attribs = $req->request->get('acl'); - foreach ($acl_attribs as $acl_key) + + if (!empty($acl_attribs)) { - $row->addACLAccess($acl_key); + foreach ($acl_attribs as $acl_key) + { + $row->addACLAccess($acl_key); + } } // validate @@ -240,9 +244,13 @@ class RoleController extends BaseController // then add $acl_attribs = $req->request->get('acl'); - foreach ($acl_attribs as $acl_key) + + if (!empty($acl_attribs)) { - $row->addACLAccess($acl_key); + foreach ($acl_attribs as $acl_key) + { + $row->addACLAccess($acl_key); + } } }