rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Fix error validation for SAP battery. #524

Browse source
This commit is contained in:
Korina Cordero 2020-11-27 10:27:01 +00:00
parent 0752fe3726
commit ac2138c1b1
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/Controller/SAPBatteryController.php
View file

@ -152,19 +152,26 @@ class SAPBatteryController extends Controller
{ {
$this->denyAccessUnlessGranted('sap_battery.add', null, 'No access.'); $this->denyAccessUnlessGranted('sap_battery.add', null, 'No access.');
// initialize error list
$error_array = [];
// create new row // create new row
$em = $this->getDoctrine()->getManager(); $em = $this->getDoctrine()->getManager();
$row = new SAPBattery(); $row = new SAPBattery();
$id = trim($req->request->get('id'));
if (empty($id))
$error_array['id'] = 'SAP code is required.';
// set and save values // set and save values
$row->setID($req->request->get('id')); $row->setID($id);
// custom validation for battery brand // custom validation for battery brand
$brand = $em->getRepository(SAPBatteryBrand::class) $brand = $em->getRepository(SAPBatteryBrand::class)
->find($req->request->get('brand')); ->find($req->request->get('brand'));
if (empty($brand)) if (empty($brand))
$error_array['brannd'] = 'Invalid brand selected.'; $error_array['brand'] = 'Invalid brand selected.';
else else
$row->setBrand($brand); $row->setBrand($brand);
@ -180,9 +187,6 @@ class SAPBatteryController extends Controller
// validate // validate
$errors = $validator->validate($row); $errors = $validator->validate($row);
// initialize error list
$error_array = [];
// add errors to list // add errors to list
foreach ($errors as $error) { foreach ($errors as $error) {
$error_array[$error->getPropertyPath()] = $error->getMessage(); $error_array[$error->getPropertyPath()] = $error->getMessage();
@ -247,8 +251,15 @@ class SAPBatteryController extends Controller
if (empty($row)) if (empty($row))
throw $this->createNotFoundException('The item does not exist'); throw $this->createNotFoundException('The item does not exist');
// initialize error list
$error_array = [];
$id = trim($req->request->get('id'));
if (empty($id))
$error_array['id'] = 'SAP code is required.';
// set and save values // set and save values
$row->setID($req->request->get('id')); $row->setID($id);
// custom validation for battery brand // custom validation for battery brand
$brand = $em->getRepository(SAPBatteryBrand::class) $brand = $em->getRepository(SAPBatteryBrand::class)
@ -271,9 +282,6 @@ class SAPBatteryController extends Controller
// validate // validate
$errors = $validator->validate($row); $errors = $validator->validate($row);
// initialize error list
$error_array = [];
// add errors to list // add errors to list
foreach ($errors as $error) { foreach ($errors as $error) {
$error_array[$error->getPropertyPath()] = $error->getMessage(); $error_array[$error->getPropertyPath()] = $error->getMessage();