rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Moved invoice code out of JO controller. #354

Browse source
This commit is contained in:
Korina Cordero 2020-02-21 03:22:17 +00:00
parent 39b9e50654
commit 9125a0d2fa
4 changed files with 39 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/Controller/JobOrderController.php
View file

@ -696,7 +696,7 @@ class JobOrderController extends Controller
$items = $req->request->get('items');
$promo_id = $req->request->get('promo');
$cvid = $req->request->get('cvid');
$service_charges = $req->request->get('service_charges');
$service_charges = $req->request->get('service_charges', []);
$em = $this->getDoctrine()->getManager();
@ -740,14 +740,7 @@ class JobOrderController extends Controller
}
*/
// TODO: this snippet should be in the invoice generator
$error = $ic->validateDiscount($criteria, $promo_id);
// process service charges
$error = $ic->invoiceServiceCharges($criteria, $service_charges);
if (!$error)
$error = $ic->invoiceBatteries($criteria, $items);
$error = $ic->generateDraftInvoice($criteria, $promo_id, $service_charges, $items);
if ($error)
{

19
src/Service/InvoiceGenerator/CMBInvoiceGenerator.php
View file

@ -204,6 +204,25 @@ class CMBInvoiceGenerator implements InvoiceGeneratorInterface
}
}
// prepare draft for invoice
public function generateDraftInvoice($criteria, $discount, $service_charges, $items)
{
$ierror = $this->validateDiscount($criteria, $discount);
if (!$ierror)
{
// process service charges
$ierror = $this->invoiceServiceCharges($criteria, $service_charges);
if (!$ierror)
{
$ierror = $this->invoiceBatteries($criteria, $items);
}
}
return $ierror;
}
protected function getTaxAmount($price)
{
$vat_ex_price = $this->getTaxExclusivePrice($price);

16
src/Service/InvoiceGenerator/ResqInvoiceGenerator.php
View file

@ -194,6 +194,20 @@ class ResqInvoiceGenerator implements InvoiceGeneratorInterface
}
}
// prepare draft for invoice
public function generateDraftInvoice($criteria, $promo_id, $service_charges, $items)
{
$ierror = $this->invoicePromo($criteria, $promo_id);
if (!$ierror)
{
$ierror = $this->invoiceBatteries($criteria, $items);
}
return $ierror;
}
protected function getTaxAmount($price)
{
$vat_ex_price = $this->getTaxExclusivePrice($price);
@ -227,7 +241,7 @@ class ResqInvoiceGenerator implements InvoiceGeneratorInterface
return 0;
}
public function invoicePromo(InvoiceCriteria $criteria, $promo_id)
protected function invoicePromo(InvoiceCriteria $criteria, $promo_id)
{
// return error if there's a problem, false otherwise
// check service type

3
src/Service/InvoiceGeneratorInterface.php
View file

@ -15,4 +15,7 @@ interface InvoiceGeneratorInterface
// generate invoice criteria
public function generateInvoiceCriteria(JobOrder $jo, int $promo_id, array $invoice_items, array &$error_array);
// prepare draft for invoice
public function generateDraftInvoice(InvoiceCriteria $criteria, int $promo_id, array $service_charges, array $items);
}