diff --git a/src/Controller/CAPI/RiderAppController.php b/src/Controller/CAPI/RiderAppController.php index 513bd3c3..ae1d5ee3 100644 --- a/src/Controller/CAPI/RiderAppController.php +++ b/src/Controller/CAPI/RiderAppController.php @@ -804,6 +804,15 @@ class RiderAppController extends ApiController if (!empty($msg)) return new APIResponse(false, $msg); + // need to check if service type is battery sales + // if so, serial is a required parameter + $serial = $req->request->get('serial', ''); + if ($jo->getServiceType() == ServiceType::BATTERY_REPLACEMENT_NEW) + { + if (empty($serial)) + return new APIResponse(false, 'Missing parameter(s): serial'); + } + // set invoice to paid $jo->getInvoice()->setStatus(InvoiceStatus::PAID); @@ -855,7 +864,6 @@ class RiderAppController extends ApiController // create warranty if($jo_handler->checkIfNewBattery($jo)) { - $serial = null; $warranty_class = $jo->getWarrantyClass(); $first_name = $jo->getCustomer()->getFirstName(); $last_name = $jo->getCustomer()->getLastName();