Add setting of taxable for invoice criteria. #744

src/Controller/TAPI/JobOrderController.php

@@ -154,6 +154,9 @@ class JobOrderController extends APIController
 
         $icrit->setCustomerVehicle($data['customer_vehicle']);
 
+        // set taxable
+        $icrit->setIsTaxable();
+
         $icrit->addEntry($data['batt'], $data['trade_in_type'], 1);
 
         // send to invoice generator

src/Service/InvoiceManager.php

@@ -153,9 +153,12 @@ class InvoiceManager implements InvoiceGeneratorInterface
         return $ierror; 
     }
 
-    // this is called by JobOrderController when JS script generateInvoice is called
+    // called by the following:
-    // this is also called by the APIController from newRequestJobOrder
+    // (1) JobOrderController when JS script generateInvoice is called
-    // this is also called by generateInvoiceCriteria
+    // (2) APIController from newRequestJobOrder
+    // (3) generateInvoiceCriteria
+    // (4) RiderAPIHandler's changeService
+    // (5) TAPI's JobOrderController
     public function generateInvoice($criteria)
     {
         // no need to validate since generateDraftInvoice was called before this was called

src/Service/RiderAPIHandler/ResqRiderAPIHandler.php

@@ -848,6 +848,9 @@ class ResqRiderAPIHandler implements RiderAPIHandlerInterface
         $crit->setCustomerVehicle($cv);
         $crit->setHasCoolant($jo->hasCoolant());
 
+        // set istaxable
+        $crit->setIsTaxable();
+
         if ($promo != null)
             $crit->addPromo($promo);