From 75b1d157b666fff74f2010566d8c72b81a2472b0 Mon Sep 17 00:00:00 2001
From: Kendrick Chan <kc@jankstudio.com>
Date: Wed, 13 May 2020 10:28:52 +0800
Subject: [PATCH] Make sure advance order flag sticks #405

---
 src/Controller/APIController.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php
index 56fc9fa5..b0f87e98 100644
--- a/src/Controller/APIController.php
+++ b/src/Controller/APIController.php
@@ -2360,10 +2360,12 @@ class APIController extends Controller implements LoggedController
         $schedule_date = $req->request->get('date_schedule');
         $slot_id = $req->request->get('slot_id');
         $advance_order = $req->request->get('flag_advance_order');
-        if ($advance_order)
-            $flag_advance_order = true;
-        else
+
+        // check for 'false' text
+        if ($advance_order === false || $advance_order === 0 || $advance_order === '0' || $advance_order == 'false')
             $flag_advance_order = false;
+        else 
+            $flag_advance_order = true;
         // $flag_advance_order = $advance_order ? true : false;
 
         $jo = new JobOrder();
@@ -2377,7 +2379,7 @@ class APIController extends Controller implements LoggedController
             ->setDeliveryInstructions($instructions)
             // TODO: error check for valid mode of payment
             ->setModeOfPayment($req->request->get('mode_of_payment'))
-            ->setAdvanceOrder($flag_advance_order);
+            ->setAdvanceOrder($advance_order);
 
         // customer
         $cust = $this->session->getCustomer();