From 5af3a3cb5ed3d59cdf5ee9a97cae2d982856b38b Mon Sep 17 00:00:00 2001
From: Ramon Gutierrez <arcticzero@gmail.com>
Date: Sat, 23 Mar 2024 04:01:16 +0800
Subject: [PATCH] Add check for if serial is present before registering
 warranty #783

---
 src/Controller/CAPI/RiderAppController.php | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/Controller/CAPI/RiderAppController.php b/src/Controller/CAPI/RiderAppController.php
index 694ffdd0..a4b50099 100644
--- a/src/Controller/CAPI/RiderAppController.php
+++ b/src/Controller/CAPI/RiderAppController.php
@@ -953,7 +953,11 @@ class RiderAppController extends ApiController
             // for riders, use rider id
             $user_id = $rider->getID();
             $source = WarrantySource::RAPI;
-            $wh->createWarranty($serial, $plate_number, $first_name, $last_name, $mobile_number, $batt_list, $date_purchase, $warranty_class, $user_id, $source, $jo->getCustomer(), $jo->getCustomerVehicle()->getVehicle());
+
+            // create warranty if serial is set
+            if (!empty($serial)) {
+                $wh->createWarranty($serial, $plate_number, $first_name, $last_name, $mobile_number, $batt_list, $date_purchase, $warranty_class, $user_id, $source, $jo->getCustomer(), $jo->getCustomerVehicle()->getVehicle());
+            }
         }
 
         // send mqtt event (fulfilled)