From f0212cc6d4a20487e4cb77511686b4d5de5f059a Mon Sep 17 00:00:00 2001
From: Korina Cordero <cordero.korina@gmail.com>
Date: Tue, 11 Feb 2020 05:54:58 +0000
Subject: [PATCH 1/2] Add checkIfNewBattery function to job order service. Add
 RiderAPIHandler to the respective services.yaml. #336

---
 config/cmb.services.yaml                            | 8 ++++++++
 config/resq.services.yaml                           | 7 +++++++
 src/Service/JobOrderHandler/CMBJobOrderHandler.php  | 8 ++++++++
 src/Service/JobOrderHandler/ResqJobOrderHandler.php | 8 ++++++++
 src/Service/JobOrderHandlerInterface.php            | 3 +++
 src/Service/RiderAPIHandler/CMBRiderAPIHandler.php  | 2 +-
 6 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/config/cmb.services.yaml b/config/cmb.services.yaml
index 4ea4926c..c069dc5f 100644
--- a/config/cmb.services.yaml
+++ b/config/cmb.services.yaml
@@ -185,6 +185,14 @@ services:
     # rider assignment interface
     App\Service\RiderAssignmentHandlerInterface: "@App\\Service\\RiderAssignmentHandler\\CMBRiderAssignmentHandler"
 
+    # rider API service
+    App\Service\RiderAPIHandler\CMBRiderAPIHandler:
+        arguments:
+            $country_code: "%env(COUNTRY_CODE)%"
+    
+    # rider API interface
+    App\Service\RiderAPIHandlerInterface: "@App\\Service\\RiderAPIHandler\\CMBRiderAPIHandler"
+
     # map manager
     #App\Service\GISManager\Bing: ~
     App\Service\GISManager\OpenStreet: ~
diff --git a/config/resq.services.yaml b/config/resq.services.yaml
index eabe0b67..1756cf98 100644
--- a/config/resq.services.yaml
+++ b/config/resq.services.yaml
@@ -185,6 +185,13 @@ services:
     # rider assignment interface
     App\Service\RiderAssignmentHandlerInterface: "@App\\Service\\RiderAssignmentHandler\\ResqRiderAssignmentHandler"
 
+    # rider API service
+    App\Service\RiderAPIHandler\ResqRiderAPIHandler: 
+        arguments:
+            $country_code: "%env(COUNTRY_CODE)%" 
+
+    App\Service\RiderAPIHandlerInterface: "@App\\Service\\RiderAPIHandler\\ResqRiderAPIHandler"
+    
     # map manager
     #App\Service\GISManager\Bing: ~
     App\Service\GISManager\OpenStreet: ~
diff --git a/src/Service/JobOrderHandler/CMBJobOrderHandler.php b/src/Service/JobOrderHandler/CMBJobOrderHandler.php
index 534b986a..6a2c1dbe 100644
--- a/src/Service/JobOrderHandler/CMBJobOrderHandler.php
+++ b/src/Service/JobOrderHandler/CMBJobOrderHandler.php
@@ -2324,6 +2324,14 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface
         return $params;
     }
 
+    public function checkIfNewBattery(JobOrder $jo)
+    {
+        if ($jo->getServiceType() == CMBServiceType::BATTERY_REPLACEMENT_NEW)
+            return true;
+
+        return false;
+    }
+
     protected function fillDropdownParameters(&$params)
     {
         $em = $this->em;
diff --git a/src/Service/JobOrderHandler/ResqJobOrderHandler.php b/src/Service/JobOrderHandler/ResqJobOrderHandler.php
index 2badddaa..27613739 100644
--- a/src/Service/JobOrderHandler/ResqJobOrderHandler.php
+++ b/src/Service/JobOrderHandler/ResqJobOrderHandler.php
@@ -2283,6 +2283,14 @@ class ResqJobOrderHandler implements JobOrderHandlerInterface
             ->setWarrantyExpiration($warr_date);
     }
 
+    public function checkIfNewBattery(JobOrder $jo)
+    {
+        if ($jo->getServiceType() == ServiceType::BATTERY_REPLACEMENT_NEW)
+            return true;
+
+        return false;
+    }
+
     protected function fillDropdownParameters(&$params)
     {
         $em = $this->em;
diff --git a/src/Service/JobOrderHandlerInterface.php b/src/Service/JobOrderHandlerInterface.php
index 92eb40da..5593d10c 100644
--- a/src/Service/JobOrderHandlerInterface.php
+++ b/src/Service/JobOrderHandlerInterface.php
@@ -95,4 +95,7 @@ interface JobOrderHandlerInterface
 
     // update customer vehicle battery warranty info
     public function updateVehicleBattery(JobOrder $jo);
+
+    // check if service type is new battery
+    public function checkIfNewBattery(JobOrder $jo);
 }
diff --git a/src/Service/RiderAPIHandler/CMBRiderAPIHandler.php b/src/Service/RiderAPIHandler/CMBRiderAPIHandler.php
index fa416e27..fb84d77d 100644
--- a/src/Service/RiderAPIHandler/CMBRiderAPIHandler.php
+++ b/src/Service/RiderAPIHandler/CMBRiderAPIHandler.php
@@ -524,7 +524,7 @@ class CMBRiderAPIHandler implements RiderAPIHandlerInterface
         $this->em->flush();
 
         // create warranty
-        if ($jo->getServiceType() == CMBServiceType::BATTERY_REPLACEMENT_NEW) 
+        if($this->jo_handler->checkIfNewBattery($jo))
         {
             $serial = null;
             $warranty_class = $jo->getWarrantyClass();

From c81a56c6e6b97c8055cfba9441fb41239d708fcc Mon Sep 17 00:00:00 2001
From: Korina Cordero <cordero.korina@gmail.com>
Date: Wed, 12 Feb 2020 02:33:14 +0000
Subject: [PATCH 2/2] Modify the checking if service type is new battery. #336

---
 src/Service/JobOrderHandler/CMBJobOrderHandler.php  | 4 ++--
 src/Service/JobOrderHandler/ResqJobOrderHandler.php | 4 ++--
 src/Service/RiderAPIHandler/ResqRiderAPIHandler.php | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Service/JobOrderHandler/CMBJobOrderHandler.php b/src/Service/JobOrderHandler/CMBJobOrderHandler.php
index aa11e4d0..40f428ee 100644
--- a/src/Service/JobOrderHandler/CMBJobOrderHandler.php
+++ b/src/Service/JobOrderHandler/CMBJobOrderHandler.php
@@ -916,7 +916,7 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface
             $this->rah->fulfillJobOrder($obj, $image_url, $rider); 
 
             // create the warranty if new battery only
-            if ($obj->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_NEW) 
+            if ($this->checkIfNewBattery($obj))
             {
                 $serial = $req->request->get('warranty_code') ;
                 $warranty_class = $obj->getWarrantyClass();
@@ -2280,7 +2280,7 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface
     public function updateVehicleBattery(JobOrder $jo)
     {
         // check if new battery
-        if ($jo->getServiceType() != CMBServiceType::BATTERY_REPLACEMENT_NEW)
+        if (!($this->checkIfNewBattery($jo)))
             return;
 
         // customer vehicle
diff --git a/src/Service/JobOrderHandler/ResqJobOrderHandler.php b/src/Service/JobOrderHandler/ResqJobOrderHandler.php
index 27613739..c6a6fa01 100644
--- a/src/Service/JobOrderHandler/ResqJobOrderHandler.php
+++ b/src/Service/JobOrderHandler/ResqJobOrderHandler.php
@@ -716,7 +716,7 @@ class ResqJobOrderHandler implements JobOrderHandlerInterface
             $this->rah->fulfillJobOrder($obj, $image_url, $rider);
 
             // create the warranty if new battery only
-            if ($obj->getServiceType () == ServiceType::BATTERY_REPLACEMENT_NEW)
+            if ($this->checkIfNewBattery($obj))
             {
                 $serial = null;
                 $warranty_class = $obj->getWarrantyClass();
@@ -2233,7 +2233,7 @@ class ResqJobOrderHandler implements JobOrderHandlerInterface
     public function updateVehicleBattery(JobOrder $jo)
     {
         // check if new battery
-        if ($jo->getServiceType() != ServiceType::BATTERY_REPLACEMENT_NEW)
+        if (!($this->checkIfNewBattery($jo)))
             return;
 
         // customer vehicle
diff --git a/src/Service/RiderAPIHandler/ResqRiderAPIHandler.php b/src/Service/RiderAPIHandler/ResqRiderAPIHandler.php
index a9ffc1b5..b5bed63b 100644
--- a/src/Service/RiderAPIHandler/ResqRiderAPIHandler.php
+++ b/src/Service/RiderAPIHandler/ResqRiderAPIHandler.php
@@ -523,7 +523,7 @@ class ResqRiderAPIHandler implements RiderAPIHandlerInterface
         $this->em->flush();
 
         // create warranty
-        if ($jo->getServiceType() == ServiceType::BATTERY_REPLACEMENT_NEW) 
+        if($this->jo_handler->checkIfNewBattery($jo))
         {
             $serial = null;
             $warranty_class = $jo->getWarrantyClass();