From 50f58960142d15cdd817c791662dc4efb72d5e58 Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Wed, 28 Apr 2021 06:00:23 +0000 Subject: [PATCH] Removing logging of no rider out of controller and into service. #554 --- src/Controller/APIController.php | 12 ------------ src/Service/HubSelector.php | 4 +++- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/Controller/APIController.php b/src/Controller/APIController.php index ff776f52..63babac0 100644 --- a/src/Controller/APIController.php +++ b/src/Controller/APIController.php @@ -1090,12 +1090,6 @@ class APIController extends Controller implements LoggedController // break out of loop break; } - else - { - // log hub into hub_filter_log - $hub_filter_logger->logFilteredHub($nearest_hub['hub'], 'no_available_rider'); - // continue to go through list to find hub with an available rider - } } } @@ -2634,12 +2628,6 @@ class APIController extends Controller implements LoggedController // break out of loop break; } - else - { - // log hub into hub_filter_log - $hub_filter_logger->logFilteredHub($nearest_hub['hub'], 'no_available_rider'); - // continue to go through list to find hub with an available rider - } } } } diff --git a/src/Service/HubSelector.php b/src/Service/HubSelector.php index c4db7a4f..046fe757 100644 --- a/src/Service/HubSelector.php +++ b/src/Service/HubSelector.php @@ -219,9 +219,11 @@ class HubSelector foreach ($riders as $rider) { if ($rider->isAvailable()) - $avail_rider_count = $avail_rider_count +1; + $avail_rider_count = $avail_rider_count + 1; } + error_log('HUB ' . $hub->getID() . ' RIDER COUNT' . $avail_rider_count); + if ($avail_rider_count > 0) $results[] = [ 'hub' => $hub,