From 26d2dab6d8504ed0cad80c249587099f588d43a9 Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Fri, 18 Oct 2019 07:07:16 +0000 Subject: [PATCH] Remove warranty creation when service type is battery replacement under warranty. #270 --- src/Controller/RAPIController.php | 6 ++---- src/Service/JobOrderHandler/CMBJobOrderHandler.php | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Controller/RAPIController.php b/src/Controller/RAPIController.php index 9cabfa86..883b8f5a 100644 --- a/src/Controller/RAPIController.php +++ b/src/Controller/RAPIController.php @@ -635,10 +635,8 @@ class RAPIController extends Controller ]; $mclient->sendEvent($jo, $payload); - // TODO: verify if we need to create warranty for battery replacement under warranty - // create the warranty if new battery or battery replacement - if (($jo->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_NEW) || - ($jo->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_WARRANTY)) + // create the warranty if new battery only + if ($jo->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_NEW) { $this->createWarranty($jo); } diff --git a/src/Service/JobOrderHandler/CMBJobOrderHandler.php b/src/Service/JobOrderHandler/CMBJobOrderHandler.php index 3186e6ae..5ac7f4c1 100644 --- a/src/Service/JobOrderHandler/CMBJobOrderHandler.php +++ b/src/Service/JobOrderHandler/CMBJobOrderHandler.php @@ -705,10 +705,8 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface $mclient->sendEvent($obj, $payload); $mclient->sendRiderEvent($obj, $payload); - // TODO: verify if we need to create warranty for battery replacement under warranty - // create the warranty if new battery or battery replacement - if (($obj->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_NEW) || - ($obj->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_WARRANTY)) + // create the warranty if new battery only + if ($obj->getServiceType () == CMBServiceType::BATTERY_REPLACEMENT_NEW) { $this->createWarranty($obj); }