From 24a0e5a2d13ceea9dff29f2d615276144f5d7ff2 Mon Sep 17 00:00:00 2001 From: Korina Cordero Date: Thu, 4 Apr 2019 09:22:31 +0000 Subject: [PATCH] Change brand and size parameters to brand_id and size_id. #201 --- catalyst/api-bundle/Command/TestCommand.php | 8 ++++---- src/Controller/CAPI/BatteryController.php | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/catalyst/api-bundle/Command/TestCommand.php b/catalyst/api-bundle/Command/TestCommand.php index 66ec639d..3d03ae0d 100644 --- a/catalyst/api-bundle/Command/TestCommand.php +++ b/catalyst/api-bundle/Command/TestCommand.php @@ -77,12 +77,12 @@ class TestCommand extends Command // add battery $sku = 'WZMB31QT-CPP00-S'; - $brand = '4'; - $size = '1'; + $brand_id = '4'; + $size_id = '1'; $params = [ 'sku' => $sku, - 'brand' => $brand, - 'size' => $size, + 'brand_id' => $brand_id, + 'size_id' => $size_id, ]; $api->post('/capi/batteries', $params); diff --git a/src/Controller/CAPI/BatteryController.php b/src/Controller/CAPI/BatteryController.php index dc035c58..ec0d65d9 100644 --- a/src/Controller/CAPI/BatteryController.php +++ b/src/Controller/CAPI/BatteryController.php @@ -81,8 +81,8 @@ class BatteryController extends APIController // required parameters $params = [ 'sku', - 'brand', - 'size', + 'brand_id', + 'size_id', ]; $msg = $this->checkRequiredParameters($req, $params); @@ -91,8 +91,8 @@ class BatteryController extends APIController return new APIResponse(false, $msg); $sku = $req->request->get('sku'); - $brand = $req->request->get('brand'); - $size = $req->request->get('size'); + $brand_id = $req->request->get('brand_id'); + $size_id = $req->request->get('size_id'); // check if sku already exists $batt = $em->getRepository(SAPBattery::class)->find($sku); @@ -100,12 +100,12 @@ class BatteryController extends APIController return new APIResponse(false, 'Battery SKU already exists.'); // check if brand exists - $batt_brand = $em->getRepository(SAPBatteryBrand::class)->find($brand); + $batt_brand = $em->getRepository(SAPBatteryBrand::class)->find($brand_id); if ($batt_brand == null) return new APIResponse(false, 'Invalid brand.'); // check if size exists - $batt_size = $em->getRepository(SAPBatterySize::class)->find($size); + $batt_size = $em->getRepository(SAPBatterySize::class)->find($size_id); if ($batt_size == null) return new APIResponse(false, 'Invalid size.');