rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Merge branch '302-memory-issue-when-running-updatecustomervehiclewarrantycommand' into 'master'

Browse source 
Resolve "Memory issue when running UpdateCustomerVehicleWarrantyCommand"

Closes #302

See merge request jankstudio/resq!340
This commit is contained in:
Kendrick Chan 2020-01-21 03:04:33 +00:00
commit 1ca2823d51
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Command/UpdateCustomerVehicleWarrantyCommand.php
View file

@ -92,7 +92,7 @@ class UpdateCustomerVehicleWarrantyCommand extends Command
} */
$this->wh->updateCustomerVehicle($serial, $batteries, $plate_number, $expiry_date);
$this->em->clear();
$this->em->detach($row[0]);
}
}
}

11
src/Service/WarrantyHandler.php
View file

@ -93,9 +93,12 @@ class WarrantyHandler
{
// find customer vehicle using plate number
error_log('Finding customer vehicle with plate number ' . $plate_number);
$cust_vehicles = $this->em->getRepository(CustomerVehicle::class)->findBy(['plate_number' => $plate_number]);
$cv_q = $this->em->createQuery('select count(cv) from App\Entity\CustomerVehicle cv where cv.plate_number = :plate_number')
->setParameter('plate_number', $plate_number);
$cv_result = $cv_q->getSingleScalarResult();
$battery_id = null;
if (!empty($cust_vehicles))
if ($cv_result != 0)
{
if (!empty($batteries))
{
@ -115,8 +118,8 @@ class WarrantyHandler
'serial' => $serial,
'expiry_date' => $date_expire,
'plate_number' => $plate_number]);
$q->execute();
}
$q->execute();
}
}
public function updateWarranty(Warranty $warr, $first_name, $last_name, $mobile_number, $batt_list, DateTime $date_purchase)