rgutierrez/resq
1
0
Fork 0
Code Issues 126 Pull requests 49 Projects Releases 4 Packages Wiki Activity Actions

Add to response the list of serials with no warranties. #372

Browse source
This commit is contained in:
Korina Cordero 2020-04-02 03:58:21 +00:00
parent 719cccf778
commit 135ab10cd3
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
catalyst/api-bundle/Command/TestAPICommand.php
View file

@ -142,7 +142,8 @@ class TestAPICommand extends Command
// get warranties given list of serial numbers // get warranties given list of serial numbers
$serial_list = [ $serial_list = [
'AJ34LJADR12134LKJM4', 'AJ34LJADR12134LKJM4',
'AJ34LJADR12134LKJL5', 'AJ34LJADR12134LKJL5',
'test',
]; ];
$params = [ $params = [

10
src/Controller/CAPI/WarrantyController.php
View file

@ -523,20 +523,22 @@ class WarrantyController extends APIController
return new APIResponse(false, 'Empty serial numbers list.'); return new APIResponse(false, 'Empty serial numbers list.');
$warranty_list = []; $warranty_list = [];
$warr_not_found_list = [];
foreach ($serial_list as $serial) foreach ($serial_list as $serial)
{ {
$clean_serial = $this->cleanSerial($serial); $clean_serial = $this->cleanSerial($serial);
$warr = $em->getRepository(Warranty::class)->findOneBy(['serial' => $clean_serial]); $warr = $em->getRepository(Warranty::class)->findOneBy(['serial' => $clean_serial]);
if ($warr == null) if ($warr == null)
return new APIResponse(false, 'No warranty found with that serial number.', null, 404); $warr_not_found_list[] = 'Warranty not found for ' . $clean_serial;
else
$warranty_list[] = $this->generateWarrantyData($warr); $warranty_list[] = $this->generateWarrantyData($warr);
} }
$data = [ $data = [
'warranties' => $warranty_list, 'warranties_found' => $warranty_list,
'warranties_not_found' => $warr_not_found_list,
]; ];
return new APIResponse(true, 'Warranties found.', $data); return new APIResponse(true, 'Warranties found.', $data);