Fix error when rider is not selected. #424

This commit is contained in:
Korina Cordero 2020-06-23 09:40:39 +00:00
parent 21ae94c5b6
commit 0f5bf2e8d6

View file

@ -558,6 +558,18 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface
} }
} }
// get discount and set to meta
$discount = $req->request->get('invoice_discount', []);
// check if discount is greater than 50 or negative number
if (($discount > 50) || ($discount < 0))
$error_array['invoice_discount'] = 'Invalid discount specified';
// get list of service charges
$service_charges = $req->request->get('service_charges', []);
if (empty($error_array))
{
// set priority based on rider's existing open job orders // set priority based on rider's existing open job orders
$rider_jos = $rider->getOpenJobOrders(); $rider_jos = $rider->getOpenJobOrders();
@ -571,18 +583,6 @@ class CMBJobOrderHandler implements JobOrderHandlerInterface
$priority = $rider_jo->getPriority() + 1; $priority = $rider_jo->getPriority() + 1;
} }
// get discount and set to meta
$discount = $req->request->get('invoice_discount', []);
// check if discount is greater than 50 or negative number
if (($discount > 50) || ($discount < 0))
$error_array['invoice_discount'] = 'Invalid discount specified';
// get list of service charges
$service_charges = $req->request->get('service_charges', []);
if (empty($error_array))
{
// get current user // get current user
$user = $this->security->getUser(); $user = $this->security->getUser();